Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass WeightInfo to the runner #1447

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

boundless-forest
Copy link
Collaborator

The WeightInfo is a unique feature in the current evm pallet, it's used to track the consumed the weight in the evm stack execution. There is no such thing in the Ethereum, so we better keep it in a single object instead of multiple places, this makes the whole logic much clearer. In this PR:

  1. I have merged the weight_limit and proof_size_base_cost into the existingWeightInfo struct and initialise it when the transaction starts to execute and pass it along to the runner.
  2. Rename it to EvmWeightInfo to avoid confiict with the one in the polkadot-sdk.

@boundless-forest boundless-forest changed the title Pass WeightInfo to the runner directly Pass WeightInfo to the runner May 31, 2024
@boundless-forest
Copy link
Collaborator Author

@librelois @sorpaas @koushiro Please take a review.

@boundless-forest
Copy link
Collaborator Author

If #1490 is approved, this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants